feat(CanvasForm): Use component Title in CanvasForm #1858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lordrip
force-pushed
the
feat/use-catalog-title
branch
from
6838f60 to
df3353f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1858 +/- ##
============================================
+ Coverage 78.62% 78.99% +0.37%
Complexity 365 365
============================================
Files 439 465 +26
Lines 14234 14561 +327
Branches 2769 2792 +23
============================================
+ Hits 11191 11502 +311
- Misses 2954 2970 +16
Partials 89 89 ☔ View full report in Codecov by Sentry. |
lordrip
force-pushed
the
feat/use-catalog-title
branch
3 times, most recently
from
b61224e to
0aa3d6f
Compare
Currently, the component name is being used as the title in the `CanvasForm`. This commit uses the corresponding `Title` property if available from components, eips and kamelets, and the `ID` as a last resort. fix: KaotoIO#1462 prerequisite of: KaotoIO#1699
lordrip
force-pushed
the
feat/use-catalog-title
branch
from
0aa3d6f to
ee781f4
Compare
|
lhein
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently, the component name is being used as the title in the
CanvasForm.Changes
This commit uses the corresponding
Titleproperty if available fromcomponents,EIPs, andKamelets, and theIDas a last resort.fix: #1462
prerequisite of: #1699