Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(351) - add option for editing route id's #465

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

tplevko
Copy link
Contributor

@tplevko tplevko commented Nov 30, 2023

fixes #351

@lordrip I know you recommended another approach in your comment.
What I did works too, updating the ID in the visual entity. For pipe - the "metadata: name: " was used, similar to kaoto-ui.

I was also thinking, whether the BaseCamelEntity "id" field is maybe redundant and should be removed.

Peek.2023-11-30.09-50.webm

Copy link
Member

@lordrip lordrip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tplevko, I like your approach for changing the IDs 👍

I was checking my new BFFs, the visual Canvas tests, and I noticed that Pipe entities are not working, very likely because of the change in the constructor signature.

image

I have a suggestion that might help in this case, would you be open to reordering the parameters in the constructor? Meaning that spec will still be the first parameter and metadata will be the second and optional one, like the following:

constructor(spec?: PipeSpec, metadata?: PipeMetadata) {

This way the existing tests will pass, and fewer changes are required.

@tplevko
Copy link
Contributor Author

tplevko commented Nov 30, 2023

thanks @lordrip for bringing this up, updated the constructor signature

@lordrip lordrip merged commit fbc6834 into KaotoIO:main Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Route ID can't be edited in canvas
2 participants