Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: This node cannot be configured yet "sticks" to other node config… #474

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

igarashitm
Copy link
Contributor

@igarashitm igarashitm commented Nov 30, 2023

…urations, even though these can be configured

Fixes: #416

@lordrip Although this fixes the issue, I don't feel like this is the best way, isn't there a way to not hold the error as a state and evaluate for every render?

@igarashitm igarashitm requested a review from lordrip November 30, 2023 16:36
@lordrip
Copy link
Member

lordrip commented Nov 30, 2023

Let me check @igarashitm

@igarashitm igarashitm marked this pull request as draft November 30, 2023 16:44
@lordrip
Copy link
Member

lordrip commented Nov 30, 2023

@igarashitm , you could try the following:

  1. Reset the ErrorBoundary component as it was
  2. In the CanvasForm component, replace line # 58 with
    <ErrorBoundary key={props.selectedNode.id} fallback={<p>This node cannot be configured yet</p>}>

Mind the key property, this tells React that despite ErrorBoundary can be reused because it doesn't have any state coming in, it needs to be reset because the key is now different.

Screencast.from.2023-11-30.17-53-49.webm

…urations, even though these can be configured

Fixes: KaotoIO#416
@igarashitm igarashitm marked this pull request as ready for review November 30, 2023 17:02
@igarashitm
Copy link
Contributor Author

Thx @lordrip it worked 👍
poke some prop to awake the component, memoed

@lordrip lordrip merged commit 0647592 into KaotoIO:main Nov 30, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

This node cannot be configured yet "sticks" to other node configurations, even though these can be configured
2 participants