Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid error when a not yet handled elements is in the source #514

Merged
merged 3 commits into from
Dec 20, 2023

Conversation

apupier
Copy link
Member

@apupier apupier commented Dec 6, 2023

for instance when there is a rest element which is not yet handled, we store the json string corresponding to it and returning it back

fixes #500

@apupier
Copy link
Member Author

apupier commented Dec 6, 2023

it requires to add tests. i think we should add for rest but also for all other elements not yet vizualized, with a specific entities, like restconfiguration, routeConfiguration

I initially thought to provide a specific identity for the rest element but it would have left apart all the other cases. So sounds safer to have a generic entity to handle all elements that we just do not want to lose but for which we are not providing a vizualization

And also need to look at all the broken tests

@lordrip
Copy link
Member

lordrip commented Dec 8, 2023

I added a fix for the tests: apupier#1

@apupier
Copy link
Member Author

apupier commented Dec 8, 2023

I added a fix for the tests: apupier#1

I also updated the tests locally but in fact the real problem introduced is that when from without route is used, it is no more working, the from route is ignored.

@apupier apupier force-pushed the 500-avoidErrorWhenRestIsInSourcecode branch from cc11d4a to a172f33 Compare December 12, 2023 13:47
@apupier
Copy link
Member Author

apupier commented Dec 12, 2023

Provided branch from Ricardo is working. i was hitting a different issue, which was already present. this issue is that routes using top-level from and which does not have a steps element (so that are incomplete route) are not displayed in the canvas. --> reported #581

So it remains to provide new tests

@lordrip
Copy link
Member

lordrip commented Dec 13, 2023

@apupier is there something that I can lend a hand with? 😃

@apupier
Copy link
Member Author

apupier commented Dec 20, 2023

is there something that I can lend a hand with? 😃

it remains to provide new tests

EDIT: I'm on it now

@apupier apupier force-pushed the 500-avoidErrorWhenRestIsInSourcecode branch from a172f33 to 758e882 Compare December 20, 2023 14:44
@apupier apupier marked this pull request as ready for review December 20, 2023 16:06
apupier and others added 3 commits December 20, 2023 17:22
for instance when there is a rest element which is not yet handled, we
store the json string corresponding to it and returning it back

fixes KaotoIO#500

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
can be serialized back

relates to KaotoIO#500

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@apupier apupier force-pushed the 500-avoidErrorWhenRestIsInSourcecode branch from 44eb298 to 11faa3b Compare December 20, 2023 16:22
@igarashitm igarashitm merged commit f2b820e into KaotoIO:main Dec 20, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config panel for Direct element from a route generated from jbang and OpenAPI is not loading
3 participants