feat(Canvas): Add dynamic labels to Canvas' nodes #556
Conversation
|
@ all sorry for the noisy diff, but since we're removing the |
lordrip
force-pushed
the
feat/add-meaningful-labels
branch
2 times, most recently
from
286af88 to
45630b1
Compare
| @@ -208,14 +207,10 @@ export class CanvasService { | |||
| return edges; | |||
| } | |||
|
|
|||
| private static getNode( | |||
| id: string, | |||
| options: { label?: string; parentNode?: string; data?: CanvasNode['data'] } = {}, | |||
There was a problem hiding this comment.
Removing label from the getNode method
| <DefaultNode element={element} showStatusDecorator {...rest}> | ||
| <g data-testid={`custom-node__${vizNode?.id}`}> | ||
| <DefaultNode element={element} label={label} truncateLength={15} {...rest} showStatusDecorator> | ||
| <g data-testid={`custom-node__${vizNode?.id}`} data-nodelabel={label}> |
There was a problem hiding this comment.
@tplevko Since long labels might be truncated, the entire label will be held in the data-nodelabel attribute, I updated the e2e commands to reflect this.
| if (camelElementLookup.componentName !== undefined) { | ||
| return camelElementLookup.componentName; | ||
| } | ||
|
|
||
| const uriString = getUriString(definition); |
There was a problem hiding this comment.
Streamlined how to extract the uri string, considering whether the definition is a string or if it's an object with a uri property in it. It also handles empty string cases.
| @@ -141,11 +146,15 @@ export class CamelComponentSchemaService { | |||
| */ | |||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | |||
| private static getCamelElement(processorName: keyof ProcessorDefinition, definition: any): ICamelElementLookupResult { | |||
| if (!isDefined(definition)) { | |||
There was a problem hiding this comment.
If there's no node definition, it's probably that the node no longer exists, so better to fallback to the processorName
lordrip
force-pushed
the
feat/add-meaningful-labels
branch
from
45630b1 to
804f4c7
Compare
|
That inline? hover looks nice 👍 |
Currently, the node's label is set once while creating the graph. This commit changes this behavior by reading the label on each node, by leveraging the new `getLabel` method in `IVisualizationNode`, `CamelRouteVisualEntity` and `PipeVisualEntity` classes. By removing the `label` property from the `data` object from `VisualizationNode`, the node id become more relevant. fix: KaotoIO#483
lordrip
force-pushed
the
feat/add-meaningful-labels
branch
from
804f4c7 to
92bbd87
Compare
Context
Currently, the node's label is set once while creating the graph.
Changes
This pull request changes this behavior by reading the label on each node, by leveraging the new
getLabelmethod inIVisualizationNode,CamelRouteVisualEntityandPipeVisualEntityclasses.By removing the
labelproperty from thedataobject fromVisualizationNode, the node id become more relevant.Screenshots
Node with a short description
Node with a long description
A longer description on hover
fix: #483