e2e: add basic bean ref tests #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igarashitm
reviewed
Dec 18, 2023
| @@ -56,10 +56,10 @@ export const NewBeanModal: FunctionComponent<NewBeanModalProps> = (props: NewBea | |||
| isOpen={props.isOpen} | |||
| onClose={handleCancel} | |||
| actions={[ | |||
| <Button key="confirm" variant="primary" onClick={handleConfirm}> | |||
| <Button key="confirm" variant="primary" onClick={handleConfirm} data-testid="creat-bean-btn"> | |||
There was a problem hiding this comment.
just one typo, creat -> create
igarashitm
reviewed
Dec 18, 2023
| uri: log:test | ||
| - beans: | ||
| - name: mysqlDataSource | ||
| type: io.kaoto.mysqlDataSource |
There was a problem hiding this comment.
Trivial but usually the class name starts with a capital letter, so MysqlDataSource or MySQLDataSource might look nice
There was a problem hiding this comment.
thanks for noticing! fixed
igarashitm
approved these changes
Dec 18, 2023
tplevko
force-pushed
the
e2e_basic_bean_ref
branch
from
3698271 to
0b05483
Compare
igarashitm
reviewed
Dec 19, 2023
| password: dbpass | ||
| driver-class-name: com.mysql.jdbc.Driver | ||
| - name: mysqlPostgreSqlSource | ||
| type: io.kaoto.mysqlPostgreSqlSource |
There was a problem hiding this comment.
Probably this one also to start the class name with a capital letter?
There was a problem hiding this comment.
thanks, didn't notice that :) Updated
tplevko
force-pushed
the
e2e_basic_bean_ref
branch
from
0b05483 to
461a581
Compare
igarashitm
force-pushed
the
e2e_basic_bean_ref
branch
from
461a581 to
02e9a56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.