chore(form): Keep defaults from user #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efault value intending to have less verbose routes. There's an issue with the `file` component, detailed as follows: ``` from: file:someFile.txt parameters: noop: true ``` In the previous route, `noop=true` implicitly set `idempotent=true` **IF THE VALUE HAS NOT BEEN SET TO EITHER TRUE OR FALSE**, usually this is OK and doesn't represent a problem. In case the user wants to set `noop=true` and `idempotent=false` to force the `file` component to re-read the files when the scheduler kicks in, like the following: ``` from: file:someFile.txt parameters: noop: true idempotent: false ``` Then we will remove the `idempotent=false` as it is the default value for the `idempotent` parameter, effectively blocking the user from setting a different behavior for the `file` component. This commit aims to keep values set by the user, even in case they are the default ones. fixes: KaotoIO#633
lordrip
force-pushed
the
chore/keep-default-values
branch
from
48d5c70 to
66ef2cf
Compare
igarashitm
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently, we're removing parameters set by the user that match the default value intending to have less verbose routes.
There's an issue with the
filecomponent, detailed as follows:In the previous route,
noop=trueimplicitly setidempotent=trueIF THE VALUE HAS NOT BEEN SET TO EITHER TRUE OR FALSE, usually this is OK and doesn't represent a problem.In case the user wants to set
noop=trueandidempotent=falseto force thefilecomponent to re-read the files when the scheduler kicks in, like the following:Then we will remove the
idempotent=falseas it is the default value for theidempotentparameter, effectively blocking the user from setting a different behavior for thefilecomponent.Changes
This commit aims to keep values set by the user, even in case they are the default ones.
Notes
We're not removing the functionality, instead, we're deactivating it while keeping the functions in separate files since they might be leveraged in the future in another fashion.
fixes: #633