feat(canvasform): Use local SchemaBridge #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lordrip
force-pushed
the
feat/use-local-schemabridge
branch
from
818bffb to
76f0b01
Compare
Currently, in case a schema contains a `oneOf` array, `uniforms` combines all `oneOf` definitions in a single schema definition. The issue with this approach is that combine potentially non-compatible schemas, like the `errorHandler` one, since we need to specify a single property. This commit extends the `getField` method from the uniforms `JSONSchemaBridge` to add the `oneOf` definitions into the field, this way, we could use this information in the form to render an UI control to select a given schema relates: KaotoIO#948 relates: KaotoIO#560
lordrip
force-pushed
the
feat/use-local-schemabridge
branch
from
76f0b01 to
dae63e8
Compare
igarashitm
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently, in case a schema contains a
oneOfarray,uniformscombines alloneOfdefinitions in a single schema definition.The issue with this approach is that it combines potentially non-compatible schemas, like the
errorHandlerone since we need to specify a single property.This commit extends the
getFieldmethod from the uniformsJSONSchemaBridgeto add theoneOfdefinitions into the field, this way, we could use this information in the form to render a UI control to select a given schemarelates: #948
relates: #560