Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to change/save any settings in User Dashboard>Preferences #1494

Closed
doasfan opened this issue Sep 1, 2022 · 11 comments · Fixed by #1525
Closed

Unable to change/save any settings in User Dashboard>Preferences #1494

doasfan opened this issue Sep 1, 2022 · 11 comments · Fixed by #1525
Labels
bug Something isn't working

Comments

@doasfan
Copy link

doasfan commented Sep 1, 2022

Version 0.5.5.1, Docker
Logged in as an admin via either Chrome on Win10, or Safari on iPadOS.

From the upper right username dropdown>Settings>Preferences>
For example: I'm unable to change any settings and get them to stick. Toggling Image Reader>Scaling Options>from "Automatic" to "Fit to Height". The "SAVE" button lights up green. I click SAVE, which highlights SAVE. I click away to the HOME button, then back in to check and Scaling Options is back to Automatic. Same with all the other dropdowns and toggles under preferences.

@majora2007 majora2007 added the needs-triage Needs to be triaged by a developer and assigned a release label Sep 1, 2022
@majora2007
Copy link
Member

When you hit save, are you seeing a success toaster saying the settings were updated?

@doasfan
Copy link
Author

doasfan commented Sep 1, 2022

No, nothing popping up in the browser. BTW, Chrome 104.0.5112.102.

kavita-after-clicking-save
kavita-after-toggling
kavita-before-changes

@majora2007
Copy link
Member

Hmm this implies the button isn't actually clicking or being registered as clicked. I have a stable release coming within a day or two and we've already ran through this flow as successful, so please wait until then (v0.5.6) and report back if this is still an issue.

@doasfan
Copy link
Author

doasfan commented Sep 1, 2022

Will do. FYI, same behavior on Microsoft Edge and on Chrome on iPhone IOS 15.6.1.

@doasfan
Copy link
Author

doasfan commented Sep 2, 2022

Upgraded to v0.5.6, still no toaster popups when toggling settings then clicking SAVE within Chrome in User Preferences. Haven't tried other browsers.

Worth mentioning that toaster popups work in the Admin Dashboard menus to confirm SAVE there.

@majora2007
Copy link
Member

Hmm I can't reproduce this. My only thought is maybe there is an error that's being recorded in the logs. Could you clear your logs, run the flow, then send me your log file?

When did you first install Kavita (version number)? Maybe some migration issue is messing the save up.

@majora2007 majora2007 added can't reproduce Can't reproduce, need additional information from user and removed needs-triage Needs to be triaged by a developer and assigned a release labels Sep 13, 2022
@jvonhoff
Copy link

Not OP, but I am affected by this bug. I noticed this (on Firefox) in the console when I click Save:

ERROR 
Array [ "The Theme field is required." ]
core.mjs:7630:22
    Angular 2
    RxJS 6
    Angular 20
    RxJS 16
    Angular 16
    RxJS 22

My logs are here:
https://gist.github.com/jvonhoff/032aaf100974d789b95734f116500a4b

I also went over to the Theme tab, which only has the default "Dark" theme. The only enabled button was Scan, so I clicked that, and once it scanned, it came back and acted the same way, so it seems that there's nothing to fix it on that tab page.

@majora2007 majora2007 added bug Something isn't working and removed can't reproduce Can't reproduce, need additional information from user labels Sep 13, 2022
@majora2007
Copy link
Member

@jvonhoff This is what I needed to deduce the issue. The issue is in fact a migration issue, where your user accounts are missing an entry to the Theme.

The way to fix this would be to add a blank css file (name it bg-dummy) in your themes directory, scan, apply that, then delete it and rescan, to get back onto the default Dark theme.

Otherwise, you can wait for me to fix the issue and release it on v0.6.0 (or nightly if you are nightly users).

@jvonhoff
Copy link

The way to fix this would be to add a blank css file (name it bg-dummy) in your themes directory, scan, apply that, then delete it and rescan, to get back onto the default Dark theme.

I can confirm that this works. I'm able to save my prefs now. Thanks!

@ghost
Copy link

ghost commented Jun 18, 2024

I have this issue again, version 0.81, browser: edge,System: Android 10

@ghost
Copy link

ghost commented Jun 18, 2024

I show saved, but the book background color has not changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants