Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot change bg color of manga reader, User Preferences -> Image Reader -> Background Color cannot change or save #1535

Closed
BenzLeung opened this issue Sep 16, 2022 · 3 comments · Fixed by #1536
Labels
bug Something isn't working UI Primarily UI impacting

Comments

@BenzLeung
Copy link

If this is a feature request, request here instead. Feature requests will be deleted from Github.

Please put as much information as possible to help me understand your issue. OS, browser, version are very important!

Describe the bug

I cannot change bg color of manga reader, User Preferences -> Image Reader -> Background Color cannot change or save.

To Reproduce
Steps to reproduce the behavior:

  1. Nav to User Preferences -> Image Reader
  2. Click and change Background Color to #ffffff.
  3. Expect Save button turn to enable, but it still disabled, not clickable.
  4. Change any other options.
  5. Save button turn to clickable, so click it.
  6. Expect Background Color is saved, but after I click Save, it return to black color #000000.

Expected behavior
Expect I can change the bg color of manga reader via user preferences.

Screenshots
N/A

Desktop (please complete the following information):

  • OS: MacOS Big sur
  • Browser: chrome
  • Version: 105

Smartphone (please complete the following information):

  • Device: Oneplus 10pro
  • OS: Android 12
  • Browser: Iceraven
  • Version: 1.17

Additional context
Kavita version: 0.5.6.0 Windows x64, served on Windows 11

@BenzLeung BenzLeung added the needs-triage Needs to be triaged by a developer and assigned a release label Sep 16, 2022
@majora2007
Copy link
Member

Can you change any settings or does #1494 maybe apply to you? There is a workaround in that issue.

@BenzLeung
Copy link
Author

All the other settings can be saved and take effect except Background Color. So it looks like I'm not having the same issue as #1494 .

@majora2007 majora2007 added bug Something isn't working UI Primarily UI impacting and removed needs-triage Needs to be triaged by a developer and assigned a release labels Sep 16, 2022
@majora2007
Copy link
Member

Thanks, looked into it and last release this got missed due to a change in when the Save button enables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working UI Primarily UI impacting
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants