Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KRKPD-1033: refactors code for userIds; updates userId tests #29

Merged
merged 1 commit into from
Apr 5, 2024
Merged

KRKPD-1033: refactors code for userIds; updates userId tests #29

merged 1 commit into from
Apr 5, 2024

Conversation

nickllerandi
Copy link

@nickllerandi nickllerandi commented Apr 4, 2024 •
edited
Loading

Type of change

  • Refactoring (no functional changes, no api changes)

Description of change

This PR refactors the getUserIds function to improve readability and maintainability.

  • Minor enhancements around code readability and maintainability.
  • Consolidated TDID handling conditions.
  • Removed unnecessary try...catch block
  • Unit tests updated to ensure support for outlier User ID sub-modules
  • Integration testing performed.

@nickllerandi nickllerandi merged commit ec820bc into master Apr 5, 2024
@nickllerandi nickllerandi deleted the krkpd-1033 branch April 5, 2024 13:39
nickllerandi added a commit that referenced this pull request Apr 9, 2024
@nickllerandi
refactors code for userIds; updates userId tests (#29) (prebid#11298)
db0b1bd 
Co-authored-by: “Nick <“nick.llerandi”@kargo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njflynn njflynn njflynn approved these changes

@elixsantana elixsantana elixsantana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickllerandi @njflynn @elixsantana