-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A 'virtual properties' attribute #3
Draft
gwillz
wants to merge
13
commits into
master
Choose a base branch
from
feat/virtual-attributes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwillz
force-pushed
the
feat/virtual-attributes
branch
2 times, most recently
from
November 4, 2022 03:15
cc345ac
to
22b31e4
Compare
This adds VirtualObject for shorthand goodness using the Configure helper. However, this doesn't gel so well with strict property types introduced in PHP 7.4. We'll likely need to rework how update() and applyVirtual() works.
gwillz
force-pushed
the
feat/virtual-attributes
branch
from
November 7, 2022 05:25
22b31e4
to
e7247c0
Compare
…ely. This permits 'strict' updates to report errors for bad types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have a very handy
UpdateVirtualTrait
that lets us apply functions whenever updating data via constructor orupdate()
. This lets us normalise or parse complex data. However, it's a little cumbersome.This lets one declare an attribute for properties that have a respective method that applies these normalisations, instead of defining them in the
virtual()
helper.There are two core attributes:
Such as:
This PR also includes a helper trait (VirtualHelperTrait) that creates helpers to configure objects on update().
Draft because:
VirtualHelperTrait
to something more obvious? Or just bundle it with the existingUpdateVirtualTrait
?applyVirtual()
isn't appropriate for strict typings in PHP 8+. This is fixed in thefeat/hooks
branch.