Add renderer backends #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BradLarson
reviewed
May 16, 2019
There was a problem hiding this comment.
I commented about this on the other PR, but I think the Renderer instances should probably be classes instead of structs due to the amount of internal mutation involved with them. That would remove a lot of the mutating references here and generally clean up the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added the renderer backends as suggested with them following a Renderer protocol and eliminating Vectorizer and VectorizerProtocol.
I've removed the save image methods from the protocol.
Please review. I'll open the next two PRs to add the LinePlot and examples once the first two are merged.