Fix logic to get local super heroes before remote if present

Karumi · Jan 29, 2019 · f6956d8 · f6956d8
1 parent 36b3c67
commit f6956d8
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/app/src/main/java/com/karumi/jetpack/superheroes/data/repository/SuperHeroRepository.kt b/app/src/main/java/com/karumi/jetpack/superheroes/data/repository/SuperHeroRepository.kt
@@ -9,15 +9,15 @@ class SuperHeroRepository(
  private val local: LocalSuperHeroDataSource,
  private val remote: RemoteSuperHeroDataSource
 ) {
- suspend fun getAllSuperHeroes(): List<SuperHero> {
- return remote.getAllSuperHeroes()
- .also { local.saveAll(it) }
- }
+ suspend fun getAllSuperHeroes(): List<SuperHero> =
+ local.getAllSuperHeroes().ifEmpty {
+ remote.getAllSuperHeroes()
+ .also { local.saveAll(it) }
+ }
 
- suspend fun get(id: String): SuperHero? {
- return local.get(id)
+ suspend fun get(id: String): SuperHero? =
+ local.get(id)
  ?: remote.get(id)?.also { local.save(it) }
- }
 
  suspend fun save(superHero: SuperHero): SuperHero = coroutineScope {
  listOf(