Issue/342 kautomator not working properly on views with several scrollables

[sergio-sastre]

This PR is built on top of the issue-306/flaky_autoscroll_when_scrollview_has_padding

It adds a UiHorizontalScrollView to allow automator to explicitly scroll on HorizontalScrollViews, in order to workaround those cases in which Kautomator autoscroll do not work (i.e. numerous scrollable views on the screen)

Remark
I'd rather merge this into issue-306 before merging into master (cannot set target branch to issue-306 though), or rather merge this into master and close the PR for the issue-306, because the code is also in this PR that aims to resolve the scrolling issues with Kautomator and Kaspresso

Closes #342

[sergio-sastre]

I believe we should also add sth abut the scrolling issues with Kaspresso (i.e. padding) and Kautomator (i.e. numerous scrollable views in the screen under test) in the readme, so that users that encounter cut problems are aware of how to workaround such problems

[eakurnikov]

Could you please change the target pr branch from master to that one? It would be easier to see the difference.
As far as I can see here it is ok.

[sergio-sastre]

Could you please change the target pr branch from master to that one? It would be easier to see the difference.
As far as I can see here it is ok.

Hi @eakurnikov !
It seems I cannot set the target branch to sergio-sastre:issue-306-..., likely because it is from a forked repo.
So I did it in the forked repo for easier reviewing
sergio-sastre#2
hope it helps :)

[eakurnikov]

@sergio-sastre hey, I've just checked it in your fork, thanks, it is ok. But we need small fixes in the included #321 to merge it

[sergio-sastre]

@sergio-sastre hey, I've just checked it in your fork, thanks, it is ok. But we need small fixes in the included #321 to merge it

Sure, I'll take a look next week. Thanks for reviewing @eakurnikov !

[sergio-sastre]

@sergio-sastre hey, I've just checked it in your fork, thanks, it is ok. But we need small fixes in the included #321 to merge it

@eakurnikov, @matzuk
So I was playing around with Kautomator, and I found a way to actually solve the autoscroll for Kautomator for real, going through all the scrollables UIAutomator finds on the screen :)

You can review this commit

I suggest to first merge the issue-306/flaky autoscroll, which I'll finish this weekend, and then I'll rebase this ticket from develop accordingly :)

[eakurnikov]

Hey @sergio-sastre , thank you a lot, sorry for the delay, I will review the changes in the nearest few days

[sergio-sastre]

Hey @sergio-sastre , thank you a lot, sorry for the delay, I will review the changes in the nearest few days

I'd like to do still some small changes.
I've realised there are 3 situations in which it does not scroll till the target view:

• ViewPagers: In general they also need to call UiScrollable#.setAsHorizontalScroll()
• RecyclerViews with LinearLayoutOrientation.HORIZONTAL: Also need call to UiScrollable#.setAsHorizontalScroll()
• Horizontal ScrollableViews in the middle of the main vertical scrolling view, not visible before starting to scroll. The changes I added do only work when those views are visible before starting any scrolling, due to the way uiAutomator works.

1 & 2 are easy to fix without affecting scrolling speed significantly. However, although I know how to solve 3, I think it might considerably decrease the scrolling speed, also for those layouts not containing horizontal ScrollableViews at all... I need to sleep on it

[sergio-sastre]

Hey @sergio-sastre , thank you a lot, sorry for the delay, I will review the changes in the nearest few days

I'd like to do still some small changes. I've realised there are 3 situations in which it does not scroll till the target view:

• ViewPagers: In general they also need to call UiScrollable#.setAsHorizontalScroll()
• RecyclerViews with LinearLayoutOrientation.HORIZONTAL: Also need call to UiScrollable#.setAsHorizontalScroll()
• Horizontal ScrollableViews in the middle of the main vertical scrolling view, not visible before starting to scroll. The changes I added do only work when those views are visible before starting any scrolling, due to the way uiAutomator works.

1 & 2 are easy to fix without affecting scrolling speed significantly. However, although I know how to solve 3, I think it might considerably decrease the scrolling speed, also for those layouts not containing horizontal ScrollableViews at all... I need to sleep on it

@RuslanMingaliev @eakurnikov @RuslanMingaliev
I've just realized that this PR does not depend on the other one regarding the error on ScrollViews with paddings...
I will close this and reopen a new one adressing this issue in the following days