TECH: snapshot publish #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 12, 2022 12:08
…ublish to snapshot repo
VladislavSumin
requested review from
matzuk,
AzamatCherchesov,
eakurnikov,
RuslanMingaliev and
Nikitae57
as code owners
AzamatCherchesov
previously approved these changes
Dec 13, 2022
RuslanMingaliev
previously approved these changes
Dec 14, 2022
| PGP_KEYID: ${{ secrets.pgp_keyid }} | ||
| PGP_KEY: ${{ secrets.pgp_key }} | ||
| PGP_PASSWORD: ${{ secrets.pgp_password }} | ||
| run: > | ||
| ./gradlew publishRelease -Pkaspresso.ossrh.user=${OSSRH_USER} | ||
| ./gradlew publishAllPublicationsTo${{ inputs.releaseType }}Repository | ||
| -Pversion=${{ inputs.version }} |
There was a problem hiding this comment.
It would be more clear if all kaspresso related parameters start with kaspresso. prefix. Up to you here.
| .forUseAtConfigurationTime() | ||
|
|
||
| val sonatypeRepoName = "SonatypeReleases" | ||
| val ossrhUsername = findProperty("kaspresso.ossrh.user")?.toString() |
There was a problem hiding this comment.
Did you check that configuration cache is not broken here?
There was a problem hiding this comment.
we don't use configuration cache. No, I'm don't check this point.
I think we check all places when we add configuration cache support
VladislavSumin
dismissed stale reviews from RuslanMingaliev and AzamatCherchesov
via
6632dfe
AzamatCherchesov
approved these changes
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor publish release pipeline && add SNAPSHOT publishing