-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PR] Keyword Argument Fix, Transform Win/Loss dictionary fix #46
Conversation
…nd complete result_dict
All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is one comment that requires clarification.
As far as the rest of the code goes if it passes the CI, it should be good to go.
recheck |
recheck ci |
average_players_stats function parameter changed and in old code keyword wasn't changed
from
average_player_features = average_player_stats( player_tracker_events=sc2_replay.trackerEvents )
to
average_player_features = average_player_stats( sc2_replay=sc2_replay )