Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR] Keyword Argument Fix, Transform Win/Loss dictionary fix #46

Closed
wants to merge 13 commits into from

Conversation

scmisa
Copy link
Contributor

@scmisa scmisa commented Aug 20, 2024

  • economy average vs outcome result dicts
  • mmr_vs_result transform incomplete dict
  • utils.select_outcome_1v1 result dict incomplete

average_players_stats function parameter changed and in old code keyword wasn't changed
from average_player_features = average_player_stats( player_tracker_events=sc2_replay.trackerEvents )
to average_player_features = average_player_stats( sc2_replay=sc2_replay )

Copy link
Contributor

github-actions bot commented Aug 20, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@scmisa
Copy link
Contributor Author

scmisa commented Aug 20, 2024

I have read the CLA Document and I hereby sign the CLA

@scmisa scmisa closed this Aug 20, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2024
@scmisa scmisa reopened this Aug 20, 2024
@Kaszanas Kaszanas changed the title Misa/dev [PR] Keyword Argument Fix, Transform Win/Loss dictionary fix Aug 20, 2024
Copy link
Owner

@Kaszanas Kaszanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one comment that requires clarification.
As far as the rest of the code goes if it passes the CI, it should be good to go.

.python-version Show resolved Hide resolved
Repository owner unlocked this conversation Aug 20, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2024
Repository owner unlocked this conversation Aug 21, 2024
@Kaszanas
Copy link
Owner

recheck

github-actions bot added a commit that referenced this pull request Aug 21, 2024
@Kaszanas
Copy link
Owner

recheck ci

@Kaszanas Kaszanas closed this Aug 21, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants