This repository has been archived by the owner on Jun 6, 2018. It is now read-only.
Update to use new rspec-puppet-facts version #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stbenjam
commented
Sep 16, 2016
•
stbenjam
commented
- Modulesync: rspec-puppet-facts updates theforeman/puppet-candlepin#51
- Modulesync: rspec-puppet-facts updates theforeman/puppet-foreman_proxy_content#95
- Modulesync: rspec-puppet-facts updates theforeman/puppet-certs#106
- Modulesync: rspec-puppet-facts updates theforeman/puppet-common#13
- Modulesync: rspec-puppet-facts updates puppet-crane#13
- Modulesync: rspec-puppet-facts updates theforeman/puppet-katello#144
- Modulesync: rspec-puppet-facts updates theforeman/puppet-katello_devel#88
stbenjam
force-pushed
the
facts
branch
2 times, most recently
from
3347976 to
786cc3d
Compare
|
ACK |
|
Best to hold on reviewing this or the linked PR's, I'm still working on this, it may need some changes |
ekohl
reviewed
Sep 16, 2016
| @@ -9,6 +9,11 @@ | |||
| require 'rspec-puppet-facts' | |||
| include RspecPuppetFacts | |||
|
|
|||
| add_custom_fact :concat_basedir, '/tmp' | |||
There was a problem hiding this comment.
Would it be useful to have a comment where each fact usually comes from? Like puppetlabs-concat in this case
stbenjam
changed the title
stbenjam
changed the title
|
@ekohl Would you mind looking again? |
ekohl
approved these changes
Sep 29, 2016
|
Thanks everyone! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.