fixes #17031 - repository info: include mirror on sync #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akofink
reviewed
Oct 20, 2016
| @@ -75,6 +76,7 @@ class InfoCommand < HammerCLIKatello::InfoCommand | |||
| def extend_data(data) | |||
There was a problem hiding this comment.
you may want to do a bit of refactoring on this method to reduce cyclomatic complexity for rubocop
There was a problem hiding this comment.
I am not sure if we can do too much to reduce this, since it is not a method that we define, but part of the general framework.
I would be tempted to either:
- disable the cop on that specific method instance
- not use the method
I prefer 1 as I really wanted to keep the behavior consistent with the other fields.
Thoughts?
There was a problem hiding this comment.
I would try to separate some of this logic into a method, like setup_sync_state does.
There was a problem hiding this comment.
Thanks @akofink ! updated.
bbuckingham
force-pushed
the
issue-17031
branch
from
32ed632 to
d8b520f
Compare
akofink
approved these changes
Oct 20, 2016
johnpmitsch
pushed a commit
to johnpmitsch/hammer-cli-katello
that referenced
this pull request
Dec 13, 2016
(cherry picked from commit d17c45e)
ehelms
pushed a commit
that referenced
this pull request
Dec 13, 2016
(cherry picked from commit d17c45e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.