Fixes #37031 - hammer proxy content info fails when DB has no content counts #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianballou
force-pushed
the
37031-fix-content-counts-empty
branch
from
9eef6df
to
6ac3418
Compare
|
The test failure seems to be happening to any PR -- I think the GH ubuntu test machine is broken somehow. It's not reproducible locally on EL7. |
chris1984
approved these changes
Jan 11, 2024
There was a problem hiding this comment.
Works great, thanks @ianballou I will figure out the test error, last time I saw this happen it was because of the seed order so half the time it would work, half the time it would fail. Here is what I did last time:
One of the files was loading before another one and didn't have the proper require.
Feel free to merge it, since it's not related.
|
Thanks @chris1984 ! I'll take a look at what you did before and see if I can't fix it with this PR. |
ianballou
force-pushed
the
37031-fix-content-counts-empty
branch
from
96f80a3
to
3295730
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test by upgrading from Katello 4.10 to 4.11 with a synced smart proxy. Run
hammer proxy content info...and see the error "undefined method each for nil"Related to Katello/katello#10835