Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support setting arbitrary servers as Puppet master and CA #250

Merged
merged 5 commits into from
Apr 19, 2018

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Apr 16, 2018

No description provided.

@beav
Copy link

beav commented Apr 16, 2018

looks good, but can you add ca_port as well?

@evgeni
Copy link
Member Author

evgeni commented Apr 16, 2018

oh dear, you can't specify ca_server = host:port? silly

@beav
Copy link

beav commented Apr 16, 2018

It might, I didn't try but if it does work it would be an undocumented feature.

https://puppet.com/docs/puppet/5.4/configuration.html#caport

@evgeni
Copy link
Member Author

evgeni commented Apr 18, 2018

@beav updated and tested :)

@sideangleside
Copy link
Member

You'd want to add a couple of print statements here to output the values of the new options when options.verbose is true, similar to what we do for the other options.

Also, update README.md (since you added new options, we have to show the users how to use them ).

Otherwise, +1 on the changes. No issues on my setup.

@evgeni
Copy link
Member Author

evgeni commented Apr 18, 2018

@sideangleside I did as you said, not as you did.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants