BZ #1659414 - don't fail on unknown smart proxies #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some scenarios (load balanced or multi homed smart proxy), the name of the proxy as seen by the client is not known to Foreman/Katello. Instead of failing, inform the user that the name could not be used for enforcing the content source/Puppet/OpenSCAP proxy and carry on.
ehelms
approved these changes
Aug 27, 2019
evgeni
added a commit
that referenced
this pull request
Sep 9, 2019
* BZ #1659414 - don't fail on unknown smart proxies (#315) * BZ #1729179 - don't migrate EL8 hosts (#317) * Puppet 6 support (#316) * BZ#1717096: only pass --remove-rhn-packages when also doing legacy purge (#313) * Open file in 'w' mode instead of 'wb' (#314) * BZ #1710546 - decode ALL results we get from rpm (#310) * update puppet config when puppet is not skipped, not foreman * move enable_rhsmcertd just after doing the subscription stuff * only execute API calls of "new capsule" mode when Foreman is not skipped * improve error message when running on an registered host
Merged
evgeni
added a commit
that referenced
this pull request
Sep 9, 2019
* BZ #1659414 - don't fail on unknown smart proxies (#315) * BZ #1729179 - don't migrate EL8 hosts (#317) * Puppet 6 support (#316) * BZ#1717096: only pass --remove-rhn-packages when also doing legacy purge (#313) * Open file in 'w' mode instead of 'wb' (#314) * BZ #1710546 - decode ALL results we get from rpm (#310) * update puppet config when puppet is not skipped, not foreman * move enable_rhsmcertd just after doing the subscription stuff * only execute API calls of "new capsule" mode when Foreman is not skipped * improve error message when running on an registered host
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some scenarios (load balanced or multi homed smart proxy), the name
of the proxy as seen by the client is not known to Foreman/Katello.
Instead of failing, inform the user that the name could not be used for
enforcing the content source/Puppet/OpenSCAP proxy and carry on.