Fixes #6927 - move checks on pulp capsule preconditions to pre_validate hook #96
Conversation
|
This can go it with theforeman/puppet-common#3 and theforeman/puppet-foreman_proxy_content#14 |
|
|
||
| if param('capsule', 'pulp') && param('capsule', 'pulp').value | ||
| if system("rpm -q katello &>/dev/null") | ||
| error "the pulp node can't be installed on a machine with Katello master" |
There was a problem hiding this comment.
What is the actual issue that arises if this is attempted?
There was a problem hiding this comment.
There are steps leading towards setting the pulp as a node, so quite possibly break the Foretello as a consequence. Not that this particular rpm would be the issue, but we need some mechanism to prevent setting the pulp node on the sat6
|
|
||
| unless system("subscription-manager identity | grep identity") | ||
| error "The system has to be registered to a Katello instance before installing the node" | ||
| end |
There was a problem hiding this comment.
might want todo:
unless system("subscription-manager identity | grep identity && ! grep -q subscription.rhn.redhat.com /etc/rhsm/rhsm.conf")
this will ensure that it is registered to the Satellite and not the Customer Portal
ACK otherwise
|
Considering this as an ACK #96 (comment) and merging |
Fixes #6927 - move checks on pulp capsule preconditions to pre_validate hook
Remove unused katello.erb
Content Views: Creating a version command
No description provided.