Skip to content
This repository has been archived by the owner on Aug 29, 2018. It is now read-only.

fixes #14858 - removes gutterball #213

Merged
merged 1 commit into from
May 27, 2016

Conversation

cfouant
Copy link
Member

@cfouant cfouant commented Apr 27, 2016

@theforeman-bot
Copy link

@cfouant, this pull request is currently not mergeable. Please rebase against the master branch and push again.

If you have a remote called 'upstream' that points to this repository, you can do this by running:

    $ git pull --rebase upstream master

This message was auto-generated by Foreman's prprocessor

@stbenjam
Copy link
Contributor

I get an install without gutterball, but trying the upgrade steps on a katello with gutterball I run into this:

[root@hi-gutterball ~]# rpm -e gutterball tfm-rubygem-foreman_gutterball tfm-rubygem-hammer_cli_gutterball
error: Failed dependencies:
    tfm-rubygem-foreman_gutterball is needed by (installed) katello-common-3.1.0-3.nightly.el7.noarch
    tfm-rubygem-hammer_cli_gutterball is needed by (installed) katello-common-3.1.0-3.nightly.el7.noarch

I think you'll need to remove those dependencies: https://github.com/Katello/katello-packaging/blob/master/katello/katello.spec#L117-L118

@cfouant cfouant force-pushed the remove-gutterball branch from 692437b to 5c4c1e1 Compare May 24, 2016 20:56
@cfouant
Copy link
Member Author

cfouant commented May 24, 2016

Thanks @stbenjam - I also removed mention of gutterball files from katello-remove... not sure if we want to keep that in or not? As in, will it be ensured that everybody utilizing this updated katello-remove will have already had gutterball removed?

@stbenjam
Copy link
Contributor

As in, will it be ensured that everybody utilizing this updated katello-remove will have already had gutterball removed?

Hm, good question, I'm not sure :) I think if they have this version of katello-remove that means they will have already run the upgrade steps, so I think we can probably remove the gutterball from katello-remove too.

@stbenjam
Copy link
Contributor

Ah I see you already removed it from katello-remove too, missed that. Looks good. Other than @ehelms comments on the installer PR, I think this is just about ready to go.

I"ll give it all another try tomorrow to make sure we didn't miss anything.

@stbenjam
Copy link
Contributor

ACK

@stbenjam stbenjam merged commit d6a7aec into Katello:master May 27, 2016
ehelms pushed a commit that referenced this pull request May 27, 2016
@cfouant cfouant deleted the remove-gutterball branch May 31, 2016 14:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants