-
Notifications
You must be signed in to change notification settings - Fork 33
Conversation
@cfouant, this pull request is currently not mergeable. Please rebase against the master branch and push again. If you have a remote called 'upstream' that points to this repository, you can do this by running:
This message was auto-generated by Foreman's prprocessor |
I get an install without gutterball, but trying the upgrade steps on a katello with gutterball I run into this:
I think you'll need to remove those dependencies: https://github.com/Katello/katello-packaging/blob/master/katello/katello.spec#L117-L118 |
692437b
to
5c4c1e1
Compare
Thanks @stbenjam - I also removed mention of gutterball files from katello-remove... not sure if we want to keep that in or not? As in, will it be ensured that everybody utilizing this updated katello-remove will have already had gutterball removed? |
Hm, good question, I'm not sure :) I think if they have this version of katello-remove that means they will have already run the upgrade steps, so I think we can probably remove the gutterball from katello-remove too. |
Ah I see you already removed it from katello-remove too, missed that. Looks good. Other than @ehelms comments on the installer PR, I think this is just about ready to go. I"ll give it all another try tomorrow to make sure we didn't miss anything. |
ACK |
(cherry picked from commit d6a7aec)
This will remove gutterball from all existing installs, and removes install of gutterball for new Satellites.
Associated PRs:
http://github.com/Katello/puppet-certs/pull/85
http://github.com/Katello/puppet-katello/pull/124
http://github.com/Katello/puppet-katello_devel/pull/74
http://github.com/Katello/katello-installer/pull/329