Fixes #38048 - Add rolling content views

[quba42]

Issue: https://projects.theforeman.org/issues/38048

Community discussion: https://community.theforeman.org/t/transparent-content-view-for-limiting-repository-access-in-katello/39389

Hammer changes to go with this feature: Katello/hammer-cli-katello#974

[nadjaheitmann]

Here is a question to @jeremylenz I guess.
I saw that you added the content_view_environment controller, recently. I am asking myself if this part of the code needs change: https://github.com/Katello/katello/blob/master/app/views/katello/api/v2/content_view_environments/show.json.rabl#L12 (and maybe some parts that use this code which I don't know :) )

[jeremylenz]

I am asking myself if this part of the code needs change: https://github.com/Katello/katello/blob/master/app/views/katello/api/v2/content_view_environments/show.json.rabl#L12 (and maybe some parts that use this code which I don't know :) )

A content view environment should be created for each rolling content view. The label would be Library/<rolling_cv_label>. (The first part would always be Library/ since rolling CVs cannot be promoted to other LCEs.)

I would expect that rabl to work "for free" - so hammer content-view-environment list would display CVEs for rolling content views with labels like I described above. Is that what you are seeing? (I haven't tested this yet)

[quba42]

A content view environment should be created for each rolling content view. The label would be Library/<rolling_cv_label>. (The first part would always be Library/ since rolling CVs cannot be promoted to other LCEs.)

I went and double checked. We are currently doing this by calling async_task(::Actions::Katello::ContentView::AddToEnvironment, @content_view.create_new_version, @content_view.organization.library) whenever we create a rolling CV. The resultant Library/<rolling_cv_label> environment is created both in the Katello and candlepin DB as expected.

I would expect that rabl to work "for free" - so hammer content-view-environment list would display CVEs for rolling content views with labels like I described above. Is that what you are seeing? (I haven't tested this yet)

I am getting Error: No such sub-command 'content-view-environment'. most likely because I am on a test instance based on Katello 4.13.1 right now. My Forklift (which is on the state of this PR) does not have Hammer installed. I will need to try to rectify this.

[quba42]

We have decided to split out the top commit on this PR into a separate PR and issue:

• Fixes #38076 - Sanitize content_view repository_ids param #11253
• https://projects.theforeman.org/issues/38076

The reasons for doing so are as follows:

• This is arguably a bug that pre-dates the changes introduced with this PR.
• The fix affects the way the API processes data, and we wanted this to receive the proper attention in review. As part of all the changes on this PR it is too easily overlooked!

[quba42]

We believe this PR is now "ready for review".

To summarize:

• As it stands, this PR requires the following to be merged first: Fixes #38076 - Sanitize content_view repository_ids param #11253, afterwards it can be rebased on top as a single commit. (Right now the change is also part of the branch for this PR).
• There is also an accompanying Hammer PR: Refs #38048 - Add rolling content views hammer-cli-katello#974
• There is also an accompanying docs PR: Add docs for rolling content views theforeman/foreman-documentation#3518
• The full list of authors and co-authors for this PR is: @Manisha15, @nadjaheitmann, @m-bucher, @sbernhard, and @quba42 with additional review by @maximiliankolb and possibly others. 😉
• The current state has experienced extensive pair programming, ATIX internal review, and ATIX internal manual testing.

[jeremylenz]

Looking great!

Tested and working pretty much as expected.
Tested with

• host assigned to multiple content view environments
• attempting to disable RH repo included in rolling CV
• attempting to remove repo from product included in rolling CV
• hammer content-view-environment list

Some outstanding UI things:

On the Red Hat Repositories page when you go to disable a repository, there's a tooltip that says "cannot be disabled because it is a part of a published content view." Should that be updated to say something like "..part of a content view" or "..part of a published or rolling content view"?

I like the icon you chose to denote rolling type (vs. CV/CCV). That should also be updated

• in new All Hosts page (ForemanColumnExtensions)
• on host details ContentViewDetails card

Some more wording (cc @maximiliankolb) and other suggestions below

[jeremylenz]

I think it will be too confusing for downstream customers to introduce a new term "Regular." We've had extensive discussion in the past about composite vs. non-composite, and what to call components of a composite content view. In the end we settled on just "Content view."

Suggested change

	title={__('Regular content view')}
	title={__('Content view')}

[jeremylenz]

(From the user perspective*) it's not the repositories that are versioned, but the content view itself. Perhaps

Contains repositories. Each version is a snapshot which must be published and may optionally be filtered.

* I know Pulp has repository versions but who knows what those are ;)

[jeremylenz]

Suggested change

	{__('Contains a set of regular content views')}
	{__('Contains a set of content views')}