Fixes #13568 - Don't create node distrbutors for yum repos #5754
Conversation
|
LGTM |
|
APJ |
|
Since we are removing nodes, should this PR go ahead and remove the nodes distributor for all repository types and not just for yum? (i.e. include docker, puppet..etc) |
|
@bbuckingham so #5750 is removing node distributors for other repo types. We could do that here as well but I guess I don't see any reason to...? |
|
@daviddavis, As long as we are fully removing the node distributors, this is perfectly fine. I just wanted to make sure we weren't only doing 'part' of the removal. |
|
APJ |
|
Does this need an upgrade task to remove these from existing repositories? |
Lazy sync doesn't support node distributors. We're removing support for pulp nodes in #13186. As a way to let lazy sync work continue, we'd like to remove the creation of node distributors in pulp for yum repositories.
theforeman-bot
added
Needs testing
Needs re-review
and removed
Waiting on contributor
labels
|
OK... I suppose thats fine as long as its handled somewhere. |
|
I can add an upgrade task to remove node distributors from existing repositories to #5750 |
|
@ehelms @johnpmitsch we were going to handle that as part of an 'upgrade' task which would be in the installer. |
|
ACK |
Fixes #13568 - Don't create node distrbutors for yum repos
Lazy sync doesn't support node distributors. We're removing support for pulp
nodes in #5750. As a way to let lazy sync work continue, we'd like to remove
the creation of node distributors in pulp for yum repositories.