Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #25135 - use i18n from webpack #7739

Merged
merged 1 commit into from
Oct 16, 2018
Merged

Fixes #25135 - use i18n from webpack #7739

merged 1 commit into from
Oct 16, 2018

Conversation

amirfefer
Copy link
Contributor

i18n (jed) is moving to webpack in foreman

__(), sprintf() and other functions should be imported

@theforeman-bot
Copy link

Issues: #25135

@waldenraines
Copy link
Contributor

[test katello]

@waldenraines
Copy link
Contributor

@amirfefer this has some linting failures.

waldenraines
waldenraines approved these changes Oct 15, 2018
View reviewed changes
Copy link
Contributor

@waldenraines waldenraines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending lenting failure(s).

@amirfefer
Copy link
Contributor Author

@waldenraines - test failures + linting has been fixed

@waldenraines waldenraines merged commit c459959 into Katello:master Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waldenraines waldenraines waldenraines approved these changes

@ohadlevy ohadlevy ohadlevy approved these changes

Assignees
No one assigned
Labels
Needs testing Not yet reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amirfefer @theforeman-bot @waldenraines @ohadlevy