Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FilesystemMixin APIs for file modifications #220

Closed
tcaiazzi opened this issue May 26, 2023 · 0 comments
Closed

Fix FilesystemMixin APIs for file modifications #220

tcaiazzi opened this issue May 26, 2023 · 0 comments
Assignees
Labels
Milestone

Comments

@tcaiazzi
Copy link
Member

tcaiazzi commented May 26, 2023

Description:
The current implementation of the FilesystemMixin APIs includes calls to the strip() method, which inadvertently disrupts the formatting of modified files.

To address this issue, we need to replace the following strip() method calls:

new_lines.append(line.strip())

new_lines.append(line.strip())

new_lines.append(line.strip())

with .replace("\n\r", "\n").replace("\r\n", "\n") to handle new line chars.

This modification will ensure that the formatting of modified files remains intact when using the FilesystemMixin APIs.

@tcaiazzi tcaiazzi self-assigned this May 26, 2023
@tcaiazzi tcaiazzi converted this from a draft issue May 26, 2023
@tcaiazzi tcaiazzi added the bug label May 26, 2023
@tcaiazzi tcaiazzi added this to the Release 3.6.5 milestone May 26, 2023
@tcaiazzi tcaiazzi changed the title Fix FilesystemMixin APIs for writing files Fix FilesystemMixin APIs for file modifications May 26, 2023
@Skazza94 Skazza94 moved this from In Progress to Done in Kathara Framework Development Board May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants