You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description:
The current implementation of DockerLink in Kathará lacks the inclusion of the lab_hash in the names of Docker networks.
This omission can lead to collision domains sharing the same name when multiple network scenarios, run by the same user, collide in the namespace.
This not only contradicts the model where Link objects have a reference to their lab but also introduces potential issues, as observed in #253.
Proposed Solution:
To resolve this issue and improve the consistency of network naming within the Kathará framework, we need to add the lab_hash in the name of Docker networks.
Then, we need to add an option in the Kathará settings to allow users to share collision domains between the network scenarios (without adding the lab_hash), as we already have for sharing collision domains between users.
The text was updated successfully, but these errors were encountered:
This commit adds the `lab_hash` to Docker networks names and adds an option in the Shared Collision Domain of the `DockerSettingsAddon` to share collision domains between network scenarios of the same user or between different users.
Description:
The current implementation of
DockerLink
in Kathará lacks the inclusion of thelab_hash
in the names of Docker networks.This omission can lead to collision domains sharing the same name when multiple network scenarios, run by the same user, collide in the namespace.
Kathara/src/Kathara/manager/docker/DockerLink.py
Lines 355 to 367 in aaa0b72
This not only contradicts the model where Link objects have a reference to their lab but also introduces potential issues, as observed in #253.
Proposed Solution:
To resolve this issue and improve the consistency of network naming within the Kathará framework, we need to add the
lab_hash
in the name of Docker networks.Then, we need to add an option in the Kathará settings to allow users to share collision domains between the network scenarios (without adding the
lab_hash
), as we already have for sharing collision domains between users.The text was updated successfully, but these errors were encountered: