Fix some issues with SqlDSEnumerator #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavoudEshtehari
commented
Mar 1, 2022
DavoudEshtehari
commented
- Native SNI with netfx and netcore has the same result as SDS
- Included some improvements and suggestions
- Improved the managed SNI result by supporting Unicode
- Managed SNI doesn't show a reasonable result (incomplete)
Added UDP Broadcast to SSRP
…Native and Managed) Added SqlDataSourceEnumerator Public API and AppContext for Helpers (Native and Managed)
Added AppContext change to unit test
…to avoid heap corruption issue
# Conflicts: # src/Microsoft.Data.SqlClient/src/Microsoft/Data/Common/AdapterUtil.cs # src/Microsoft.Data.SqlClient/tests/FunctionalTests/Microsoft.Data.SqlClient.Tests.csproj
…a from SQL Browser
exclude appcontext test
Comments and url references
review comment
fix strbuilder overwrite
VS Suggestions
EventSource Trace
Documentation and ref
moved sni native wrapper methods from windows to common
reverting back test nuget version
Co-authored-by: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
removing body expression from SNIServerEnumClose
body expression for GetTimeoutSeconds
created util for sqldatasourceenumerator
more utils
|
wrong target |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.