feat(cli): patch cometbft to support rollbacks of >1 block #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirtleshell
requested review from
DracoLi,
nddeluca,
rhuairahrighairidh,
galxy25,
karzak,
drklee3 and
evgeniy-scherbina
pirtleshell
force-pushed
the
rp-rollback-hard-flag
branch
from
a7da156
to
1063a20
Compare
2 tasks
drklee3
approved these changes
Dec 6, 2023
nddeluca
pushed a commit
that referenced
this pull request
Jan 9, 2024
* feat(cli): patch cometbft to support rollbacks of >1 block * update to tagged cometbft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Kava-Labs/cometbft#2 for full details of the underlying cometbft change.
Brings in the above patch & updates the method signature of
Rollbackto include the new argument. Therollbackcommand now accepts a--hardflag that allows sequential rollbacks of multiple blocks in the store.