cli: add --unsafe-remove-modules flag to Rollback #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* rollback command accepts list of store keys names to forcibly delete this is useful for rolling back an upgrade that adds modules. rollbacks are performed by loading & committing the previous version. without this new functionality, the rollback will fail because no store version will exist for modules added during the upgrade. to properly rollback the state, pass in a list of the added module names and they will be completely removed before the rollback of pre-existing modules takes place: ``` chain rollback --unsafe-remove-modules mynewmodule,othernewmodule ```
pirtleshell
requested review from
DracoLi,
nddeluca,
rhuairahrighairidh,
drklee3 and
evgeniy-scherbina
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+1029
to
+1034
| for k := range rs.storesParams { | ||
| if k.Name() == keyName { | ||
| key = k | ||
| break | ||
| } | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
pirtleshell
added a commit
that referenced
this pull request
Aug 1, 2024
* rollback command accepts list of store keys names to forcibly delete this is useful for rolling back an upgrade that adds modules. rollbacks are performed by loading & committing the previous version. without this new functionality, the rollback will fail because no store version will exist for modules added during the upgrade. to properly rollback the state, pass in a list of the added module names and they will be completely removed before the rollback of pre-existing modules takes place: ``` chain rollback --unsafe-remove-modules mynewmodule,othernewmodule ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
like #546 but using our mainnet (iavl v0) cosmos-sdk branch as the base
i originally went about exposing
DeleteVersionsFromon the iavl tree (Kava-Labs/iavl#1), but realized i could just use the already-existingDeleteVersioninstead of adding another forked dependency to maintain.this is useful for rolling back an upgrade that adds modules.
rollbacks are performed by loading & committing the previous version.
without this new functionality, the rollback will fail because no store
version will exist for modules added during the upgrade.
to properly rollback the state, pass in a list of the added module names
and they will be completely removed before the rollback of pre-existing
modules takes place:
Currently testing this works as expected.