Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmos v0.46 upgrade follow ups #1522

Merged
merged 3 commits into from
Apr 6, 2023

Conversation

rhuairahrighairidh
Copy link
Member

@rhuairahrighairidh rhuairahrighairidh commented Mar 31, 2023

minor fixes from code review

  • noticed there's a new rename key command
  • the test for RewardIndexes.Mul wasn't calling Mul
    • This (perf: add inplace decimal operations cosmos/cosmos-sdk#11004) change in sdk.Dec math introduced a change to the Mul function.
    • Previously sdk.OneDec().Mul(sdk.Zerodec()) would be exactly equal to sdk.ZeroDec()
    • with sdk.ZeroDec() being sdk.Dec{&big.Int{neg: false, abs: nil}}, eg an empty big.Int value.
    • However now the result is not exactly equal to sdk.ZeroDec() it's now sdk.Dec{&big.Int{neg: false, abs: nat{}}}, eg the nat slice inside the big.Int has been initialised.
    • This shouldn't change any of our calculations as they don't differentiate between initialised and uninitialised values.
  • registered all kava msgs on the authz codec. This is to ensure authz.MsgExec signatures are only valid for the contained msg type. See https://kava-labs.atlassian.net/wiki/spaces/ENG/pages/1237483521/Legacy+Amino+Codec+Registration

Base automatically changed from dl-cosmos-v.46 to master April 4, 2023 00:08
@rhuairahrighairidh rhuairahrighairidh force-pushed the ro-cosmos-sdk-v0.46-follow-ups branch from 53de9c2 to 5113c59 Compare April 4, 2023 13:05
@rhuairahrighairidh rhuairahrighairidh merged commit 5b3162c into master Apr 6, 2023
@rhuairahrighairidh rhuairahrighairidh deleted the ro-cosmos-sdk-v0.46-follow-ups branch April 6, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants