Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(evmutil): create module account on InitGenesis #1655

Merged
merged 3 commits into from
Jul 24, 2023

Conversation

pirtleshell
Copy link
Member

@pirtleshell pirtleshell commented Jul 21, 2023

Description

ensures the creation of the x/evmutil module account on init genesis.

this is non-state breaking because mainnet will never call init genesis. additionally, the module account already exists on mainnet.

Checklist

  • Changelog has been updated as necessary.

ensures the creation of the x/evmutil module account on init genesis.
Copy link
Member

@rhuairahrighairidh rhuairahrighairidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, I reviewed it against the security questionnaire and merge checklist and everything looks good. Thought there was some state breaking changes, but error text is non breaking, and unpackERC20ResToBigInt is only used by queriers.

@pirtleshell pirtleshell merged commit 15c2432 into master Jul 24, 2023
@pirtleshell pirtleshell deleted the rp-evmutil-init-genesis-account branch July 24, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants