feat(metrics): add timing metrics to abci methods #1669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirtleshell
requested review from
DracoLi,
nddeluca,
rhuairahrighairidh,
galxy25,
drklee3 and
evgeniy-scherbina
drklee3
approved these changes
Aug 24, 2023
galxy25
approved these changes
Aug 24, 2023
pirtleshell
force-pushed
the
rp-abci-timings
branch
from
2a073a0 to
f4b2493
Compare
pirtleshell
added
the
A:backport/kava_2222-10
mergify bot
pushed a commit
that referenced
this pull request
Aug 25, 2023
* feat(metrics): add timing metrics to abci methods * update changelog (cherry picked from commit 8b6bbd3) # Conflicts: # CHANGELOG.md # x/incentive/abci.go
mergify bot
pushed a commit
that referenced
this pull request
Aug 25, 2023
* feat(metrics): add timing metrics to abci methods * update changelog (cherry picked from commit 8b6bbd3) # Conflicts: # CHANGELOG.md # x/incentive/abci.go
mergify bot
pushed a commit
that referenced
this pull request
Aug 25, 2023
* feat(metrics): add timing metrics to abci methods * update changelog (cherry picked from commit 8b6bbd3) # Conflicts: # CHANGELOG.md
This was referenced Aug 25, 2023
mergify bot
pushed a commit
that referenced
this pull request
Aug 25, 2023
* feat(metrics): add timing metrics to abci methods * update changelog (cherry picked from commit 8b6bbd3) # Conflicts: # CHANGELOG.md
mergify bot
pushed a commit
that referenced
this pull request
Aug 25, 2023
* feat(metrics): add timing metrics to abci methods * update changelog (cherry picked from commit 8b6bbd3) # Conflicts: # CHANGELOG.md
mergify bot
pushed a commit
that referenced
this pull request
Aug 25, 2023
* feat(metrics): add timing metrics to abci methods * update changelog (cherry picked from commit 8b6bbd3) # Conflicts: # CHANGELOG.md
This was referenced Aug 25, 2023
pirtleshell
added a commit
that referenced
this pull request
Aug 25, 2023
…1680) * feat(metrics): add timing metrics to abci methods (#1669) * feat(metrics): add timing metrics to abci methods * update changelog (cherry picked from commit 8b6bbd3) # Conflicts: # CHANGELOG.md # x/incentive/abci.go * fix merge conflicts --------- Co-authored-by: Robert Pirtle <Astropirtle@gmail.com>
pirtleshell
added a commit
that referenced
this pull request
Aug 25, 2023
…1681) * feat(metrics): add timing metrics to abci methods (#1669) * feat(metrics): add timing metrics to abci methods * update changelog (cherry picked from commit 8b6bbd3) # Conflicts: # CHANGELOG.md # x/incentive/abci.go * fix merge conflicts --------- Co-authored-by: Robert Pirtle <Astropirtle@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds timing metrics to all Begin & End Blockers. When telemetry is enabled, the chain will now broadcast metrics that track how long each Begin/EndBlocker takes for each module. This matches how cosmos-sdk times their modules and allows higher fidelity in tracking performance of the chain.
Checklist