Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(community): consolidate community funds #1729

Merged
merged 18 commits into from
Oct 20, 2023

Conversation

drklee3
Copy link
Member

@drklee3 drklee3 commented Sep 18, 2023

Description

  • Transfer x/distribution communitypool and x/kavadist (non-ukava) account funds to x/community

Checklist

  • Changelog has been updated as necessary.

@drklee3 drklee3 marked this pull request as ready for review September 18, 2023 23:21
Copy link
Contributor

@DracoLi DracoLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

x/community/keeper/incentives.go Outdated Show resolved Hide resolved
x/community/keeper/incentives_test.go Outdated Show resolved Hide resolved
x/community/keeper/incentives.go Outdated Show resolved Hide resolved
x/community/keeper/incentives_test.go Outdated Show resolved Hide resolved
@drklee3 drklee3 force-pushed the dl-incentive-consolidate-community-funds branch 2 times, most recently from 9e3ad12 to 33a41e7 Compare September 20, 2023 20:47
@nddeluca nddeluca force-pushed the dl/incentives-inflation-upgrade branch from 4cdddde to 317e5b4 Compare September 26, 2023 17:43
@drklee3 drklee3 force-pushed the dl-incentive-consolidate-community-funds branch from ac51d49 to 02fe814 Compare September 27, 2023 09:10
Base automatically changed from dl/incentives-inflation-upgrade to master October 2, 2023 20:10
@drklee3 drklee3 force-pushed the dl-incentive-consolidate-community-funds branch from 02fe814 to bee4928 Compare October 4, 2023 15:13
kavadisttypes "github.com/kava-labs/kava/x/kavadist/types"
)

func (suite *disableInflationTestSuite) TestStartCommunityFundConsolidation() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great coverage 👍

@@ -11,10 +11,6 @@ import (
"github.com/kava-labs/kava/x/community/types"
)

const (
ModuleName = "mint"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

kavadisttypes.ModuleName,
tc.initialKavadistBalance,
)
suite.NoError(err, "x/kavadist account should be funded without error")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice error messages, very helpful

@@ -40,7 +40,7 @@ func (suite *HandlerTestSuite) TestPayoutHardClaimMultiDenom() {

// Claim denoms
err := suite.DeliverIncentiveMsg(&msg)
suite.NoError(err)
suite.Require().NoError(err)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nddeluca nddeluca force-pushed the dl-incentive-consolidate-community-funds branch from 548c37f to 0727d9c Compare October 20, 2023 00:20
@nddeluca nddeluca merged commit 8186367 into master Oct 20, 2023
10 checks passed
@nddeluca nddeluca deleted the dl-incentive-consolidate-community-funds branch October 20, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants