Correct rocksdb path -- ensure we use KAVA_HOME/data/application.db #1767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and not a nested application.db within that path
drklee3
approved these changes
Nov 7, 2023
pirtleshell
approved these changes
Nov 7, 2023
galxy25
reviewed
Nov 7, 2023
| @@ -90,7 +90,8 @@ func OpenDB(appOpts types.AppOptions, home string, backendType dbm.BackendType) | |||
| // openRocksdb loads existing options, overrides some of them with appOpts and opens database | |||
| // option will be overridden only in case if it explicitly specified in appOpts | |||
| func openRocksdb(dir string, appOpts types.AppOptions) (dbm.DB, error) { | |||
| dbOpts, cfOpts, err := loadLatestOptions(dir) | |||
| optionsPath := filepath.Join(dir, "application.db") | |||
There was a problem hiding this comment.
should we move this to being sourced from config.yml?
There was a problem hiding this comment.
ya agree, we can implement a better fix on master w/ an integration test to ensure path doesn't change in the future
galxy25
approved these changes
Nov 7, 2023
pirtleshell
pushed a commit
that referenced
this pull request
Nov 20, 2023
…1767) and not a nested application.db within that path
pirtleshell
pushed a commit
that referenced
this pull request
Nov 20, 2023
ensure we use KAVA_HOME/data/application.db and not a nested application.db within that path
1 task
pirtleshell
added a commit
that referenced
this pull request
Nov 20, 2023
pirtleshell
added a commit
that referenced
this pull request
Nov 20, 2023
…#1777) * fix(rocksdb): correctly resolve rocksdb path (#1767) (#1776) * fix(rocksdb): correctly resolve rocksdb path (#1767) ensure we use KAVA_HOME/data/application.db and not a nested application.db within that path * update changelog --------- Co-authored-by: Nick DeLuca <nickdeluca08@gmail.com> (cherry picked from commit aca738f) # Conflicts: # CHANGELOG.md * update changelog --------- Co-authored-by: Robert Pirtle <Astropirtle@gmail.com>
pirtleshell
added a commit
that referenced
this pull request
Nov 20, 2023
…#1778) * fix(rocksdb): correctly resolve rocksdb path (#1767) (#1776) * fix(rocksdb): correctly resolve rocksdb path (#1767) ensure we use KAVA_HOME/data/application.db and not a nested application.db within that path * update changelog --------- Co-authored-by: Nick DeLuca <nickdeluca08@gmail.com> (cherry picked from commit aca738f) # Conflicts: # CHANGELOG.md * update changelog --------- Co-authored-by: Robert Pirtle <Astropirtle@gmail.com>
pirtleshell
added a commit
that referenced
this pull request
Nov 21, 2023
…#1782) * fix(rocksdb): correctly resolve rocksdb path (#1767) (#1776) * fix(rocksdb): correctly resolve rocksdb path (#1767) ensure we use KAVA_HOME/data/application.db and not a nested application.db within that path * update changelog --------- Co-authored-by: Nick DeLuca <nickdeluca08@gmail.com> (cherry picked from commit aca738f) * update changelog --------- Co-authored-by: Robert Pirtle <Astropirtle@gmail.com>
pirtleshell
added a commit
that referenced
this pull request
Nov 21, 2023
…#1779) * fix(rocksdb): correctly resolve rocksdb path (#1767) (#1776) * fix(rocksdb): correctly resolve rocksdb path (#1767) ensure we use KAVA_HOME/data/application.db and not a nested application.db within that path * update changelog --------- Co-authored-by: Nick DeLuca <nickdeluca08@gmail.com> (cherry picked from commit aca738f) # Conflicts: # CHANGELOG.md * update changelog * disable remote proto braking ci check --------- Co-authored-by: Robert Pirtle <Astropirtle@gmail.com>
galxy25
pushed a commit
that referenced
this pull request
Dec 5, 2023
…#1782) * fix(rocksdb): correctly resolve rocksdb path (#1767) (#1776) * fix(rocksdb): correctly resolve rocksdb path (#1767) ensure we use KAVA_HOME/data/application.db and not a nested application.db within that path * update changelog --------- Co-authored-by: Nick DeLuca <nickdeluca08@gmail.com> (cherry picked from commit aca738f) * update changelog --------- Co-authored-by: Robert Pirtle <Astropirtle@gmail.com>
galxy25
pushed a commit
that referenced
this pull request
Dec 5, 2023
…#1782) * fix(rocksdb): correctly resolve rocksdb path (#1767) (#1776) * fix(rocksdb): correctly resolve rocksdb path (#1767) ensure we use KAVA_HOME/data/application.db and not a nested application.db within that path * update changelog --------- Co-authored-by: Nick DeLuca <nickdeluca08@gmail.com> (cherry picked from commit aca738f) * update changelog --------- Co-authored-by: Robert Pirtle <Astropirtle@gmail.com>
pirtleshell
added a commit
that referenced
this pull request
Jan 4, 2024
…#1780) * fix(rocksdb): correctly resolve rocksdb path (#1767) (#1776) * fix(rocksdb): correctly resolve rocksdb path (#1767) ensure we use KAVA_HOME/data/application.db and not a nested application.db within that path * update changelog --------- Co-authored-by: Nick DeLuca <nickdeluca08@gmail.com> (cherry picked from commit aca738f) # Conflicts: # CHANGELOG.md * update changelog * update golangci-lint job --------- Co-authored-by: Robert Pirtle <Astropirtle@gmail.com>
pirtleshell
added a commit
that referenced
this pull request
Jan 4, 2024
…#1781) * fix(rocksdb): correctly resolve rocksdb path (#1767) (#1776) * fix(rocksdb): correctly resolve rocksdb path (#1767) ensure we use KAVA_HOME/data/application.db and not a nested application.db within that path * update changelog --------- Co-authored-by: Nick DeLuca <nickdeluca08@gmail.com> (cherry picked from commit aca738f) # Conflicts: # CHANGELOG.md * update changelog * update golangci-lint job --------- Co-authored-by: Robert Pirtle <Astropirtle@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.