Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to sdk v0.39.x #625

Merged
merged 14 commits into from
Sep 16, 2020
Merged

Update to sdk v0.39.x #625

merged 14 commits into from
Sep 16, 2020

Conversation

rhuairahrighairidh
Copy link
Member

@rhuairahrighairidh rhuairahrighairidh commented Aug 14, 2020

Changes (to kava):

  • remove the monkey patch in cmd/kvd that disabled pruning=syncable. The new pruning options are default, nothing, everything
  • merged in the fix for the cli tests from Fix cli tests #609, added a new test for sending multiple transactions per block (in cli_test/)
  • updated the json serialization of ValidatorVestingAccounts to match the new format in v0.39

Changes in v0.39: https://github.com/cosmos/cosmos-sdk/blob/v0.39.1/CHANGELOG.md

Tests:

  • Ran a 4 node local testnet (with a script that continusously sent ~16 txs per block) and restarted 1 node 20 or so times with varying pruning configs. Could not replicate the previous issue: Logical Commit(s) are not Atomic cosmos/cosmos-sdk#6370. I was able to replicate the issue by restarting the node many times on kvd v0.10.0.
  • Ran MsgSend and MsgCreateCDP with cosmos ledger app

Todo for external parties

  • validators will probably want to update their app.toml pruning config (in most cases to pruning=default)
  • rest consumers who query accounts will need to update - notably account numbers and sequences are now strings rather than numbers
  • Any workarounds around not sending multiple txs per block can be removed now.

TODOs (for later PRs)

  • write migrations to transform 38 account json into 39 json
  • update swagger (and rest tests?)

@rhuairahrighairidh rhuairahrighairidh changed the title Experimental update to sdk v0.39.x Update to sdk v0.39.x Sep 1, 2020
@rhuairahrighairidh rhuairahrighairidh marked this pull request as ready for review September 2, 2020 15:56
@rhuairahrighairidh rhuairahrighairidh added the R4R When a PR is ready for review label Sep 2, 2020
@karzak karzak merged commit 64aa61d into master Sep 16, 2020
@karzak karzak deleted the ro-update-to-sdk-v0.39 branch September 16, 2020 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R4R When a PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants