Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incentive PR 4: claim Hard rewards via the Incentive module #780

Merged
merged 7 commits into from
Jan 26, 2021
Merged

Incentive PR 4: claim Hard rewards via the Incentive module #780

merged 7 commits into from
Jan 26, 2021

Conversation

denalimarsh
Copy link
Contributor

  • Add message for hard rewards claims that allow users to claim rewards
  • Message claims all (supply, borrow, delegation) HARD rewards and deletes the claim object from the store
  • CLI/Rest API should also be updated for new transaction types
  • Added basic Hard claims queries

Questions:

  • What should the Incentive module's API look like (Hard module vs. CDP module claims)?

@denalimarsh denalimarsh added the R4R When a PR is ready for review label Jan 25, 2021
@denalimarsh denalimarsh requested a review from karzak January 25, 2021 19:42
karzak
karzak approved these changes Jan 26, 2021
View reviewed changes
Copy link
Member

@karzak karzak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nits, otherwise LGTM.

x/incentive/keeper/payout.go Outdated Show resolved Hide resolved
x/incentive/keeper/payout.go Show resolved Hide resolved
@denalimarsh denalimarsh merged commit 3a08fc5 into master Jan 26, 2021
@denalimarsh denalimarsh deleted the dm-hard-incentive-rewards-4 branch January 26, 2021 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karzak karzak karzak approved these changes

Assignees
No one assigned
Labels
R4R When a PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denalimarsh @karzak