Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R4R] add community multi-spend proposal #915

Merged
merged 12 commits into from
Jun 2, 2021

Conversation

karzak
Copy link
Member

@karzak karzak commented May 24, 2021

Implements a new gov proposal for spending from the community pool and sending funds to multiple addresses at once.

Did a basic test with kvtool and was able to submit a proposal

Did some gas testing with kvtool - this example spends coins to 250 `PeriodicVestingAccounts that have average ~10 vesting periods.

To replicate:

# From kvtool directory
git checkout kd-community-spend
make install
kvtool testnet bootstrap --kava.configTemplate master 

# copy proposal to docker container
docker cp big-multi-spend-example.json generated_kavanode_1:/root/kava/multi-spend-example.json

# submit proposal
dkvcli tx gov submit-proposal community-pool-multi-spend multi-spend-example.json --from user1 --gas 10000000

# uses about 40% of block gas
# gasused: 8398012

@karzak karzak added the R4R When a PR is ready for review label May 24, 2021
@karzak karzak changed the title add community multi-spend proposal [R4R] add community multi-spend proposal May 24, 2021
Copy link
Member

@rhuairahrighairidh rhuairahrighairidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but haven't done any testing yet

Is this change to be released as an async upgrade? Currently it will fork if someone submits the new proposal.

One nit is that it'd be nice if the proposal wasn't in kavadist as it doesn't share functionality. But I can't think of a better place to put it.

@karzak karzak merged commit fc85052 into master Jun 2, 2021
@karzak karzak deleted the kd-add-community-multi-spend-proposal branch June 2, 2021 17:03
karzak added a commit that referenced this pull request Jun 2, 2021
* feat: add community multi-spend proposal type

* feat: add handler for community multi-spend proposals

* chore: register new community multi-spend proposal

* feat: define client for community multi-spend proposal

* fix typos in example cli json

* fix: register now proposal type with module codec

* fix: register community multi-spend proposal with gov router, not committee

* fix: define kavadist keeper before referencing it

* nit: include deposit in example proposal

* nit: update comment

* nit: fix error codes

* nit: update comments
karzak added a commit that referenced this pull request Jun 7, 2021
* feat: add community multi-spend proposal type

* feat: add handler for community multi-spend proposals

* chore: register new community multi-spend proposal

* feat: define client for community multi-spend proposal

* fix typos in example cli json

* fix: register now proposal type with module codec

* fix: register community multi-spend proposal with gov router, not committee

* fix: define kavadist keeper before referencing it

* nit: include deposit in example proposal

* nit: update comment

* nit: fix error codes

* nit: update comments
nddeluca pushed a commit that referenced this pull request Jun 10, 2021
* feat: add community multi-spend proposal type

* feat: add handler for community multi-spend proposals

* chore: register new community multi-spend proposal

* feat: define client for community multi-spend proposal

* fix typos in example cli json

* fix: register now proposal type with module codec

* fix: register community multi-spend proposal with gov router, not committee

* fix: define kavadist keeper before referencing it

* nit: include deposit in example proposal

* nit: update comment

* nit: fix error codes

* nit: update comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R4R When a PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants