Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating fork july release branch #3

Merged

Conversation

Kawilki-M
Copy link
Owner

…sedRoute and virtualRouterPeerLearnedRoute (Azure#10736)

  • Add virtual hub bgp connections subresources virtualRouterPeerAdvertisedRoute and virtualRouterPeerLearnedRoute with POST opertion

  • Add examples

  • Change name of operationid

  • change output of advertised route

  • Add PUT InboundSecurityRules for NVA

  • merge

  • Add examples

  • merge

  • merge

  • change output of advertised route

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

…sedRoute and virtualRouterPeerLearnedRoute (#10736)

* Add virtual hub bgp connections subresources virtualRouterPeerAdvertisedRoute and virtualRouterPeerLearnedRoute with POST opertion

* Add examples

* Change name of operationid

* change output of advertised route

* Add PUT InboundSecurityRules for NVA

* merge

* Add examples

* merge

* merge

* change output of advertised route
@Kawilki-M Kawilki-M merged commit d30d94c into Kawilki-M:network-july-release Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants