Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.3.0 #22

Merged
merged 5 commits into from
Mar 31, 2018
Merged

1.3.0 #22

merged 5 commits into from
Mar 31, 2018

Conversation

Raiondesu
Copy link
Contributor

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

Bug fix, feature and docs update. This PR closes #19 .

What is the current behavior? What is the new behavior (if this is a feature change)?

See #19

Does this PR introduce a breaking change?

Yes. The input events (select, input, hover) now adapt to the current list input whatever the internal converted structure is. It means that events are now emitted with different arguments than in the previous version.

Also there are some minor not logged bug-fixes.

@Raiondesu Raiondesu requested a review from kaskar2008 March 31, 2018 00:32
@Raiondesu Raiondesu added bug Something isn't working enhancement New feature or request refactoring Code smells, needs refactoring labels Mar 31, 2018
@Raiondesu Raiondesu merged commit c657686 into master Mar 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request refactoring Code smells, needs refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Main input events take object as an argument regardless of the list structure
2 participants