ContainerHelper: Added tests #44
Conversation
| $container = $this->prepareConfigurator()->createContainer(); | ||
|
|
||
| /** @var Kdyby\Console\Application $app */ | ||
| $app = $container->getByType('Kdyby\Console\Application'); |
There was a problem hiding this comment.
I don't think you need to compile the container and run the app to test that those three new methods work. Unit test would suffice perfectly.
There was a problem hiding this comment.
So if I understand correctly you want me to test just the ContainerHelper with some sort of Container mock? (newbie to testing)
There was a problem hiding this comment.
You probably don't even have to mock the container, just use new Nette\DI\Container() and pass some arguments and the do asserts on the helper
|
Alright, is it better now? Shall I add test for |
| public function testParameters() | ||
| { | ||
| Debugger::$logDirectory = TEMP_DIR . '/log'; | ||
| Tester\Helpers::purge(Debugger::$logDirectory); |
There was a problem hiding this comment.
what are theese two lines for?
There was a problem hiding this comment.
Beats me, I had some weird errors before I rewrote that test, I will try to remove them.
juniwalk
changed the title
|
Okay it works now, was probably because I was building container before. |
|
Cool, thanks 👍 |
ContainerHelper: Added tests
I must say, working with PHPUnit seems so much easier to me.
Anyway here is a draft of a tests, let's see how it goes.