Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix detection of nette/application #56

Merged
merged 1 commit into from
May 1, 2016
Merged

Conversation

enumag
Copy link
Member

@enumag enumag commented May 1, 2016

Currently some of my tests are failing with

[Nette\DI\MissingServiceException] Service 'application' not found.

because I have nette/application in dev dependencies but don't use it in all the tests. The problem occurs if a test uses ConsoleExtension without ApplicationExtension.

@fprochazka Should I refactor it to a property like I did here? Personally I like it better than a method.

@fprochazka
Copy link
Member

@enumag yeah, this way it's more logical. The property is faster, but the method is imho cleaner. And you can always add the property inside the check method, to make it faster, if that's needed.

@enumag
Copy link
Member Author

enumag commented May 1, 2016

@fprochazka Speed is not relevant here so let's leave it as is.

@fprochazka fprochazka merged commit 8021d40 into Kdyby:master May 1, 2016
@fprochazka
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants