Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7.2 compatibility #307

Merged
merged 3 commits into from
Dec 3, 2017
Merged

PHP 7.2 compatibility #307

merged 3 commits into from
Dec 3, 2017

Conversation

xificurk
Copy link
Contributor

Getting rid of Nette\Object that cannot be used in PHP 7.2

@xificurk
Copy link
Contributor Author

xificurk commented Oct 31, 2017

The build against dev dependencies passes, but at the moment there are no stable versions of kdyby/doctrine-cache, kdyby/events, kdyby/console compatible with PHP 7.2.

@enumag
Copy link
Member

enumag commented Dec 3, 2017

@xificurk Could you rebase this to the 3.2 branch? I'll release 7.2 compatible versions for Console and Events soon.

@xificurk xificurk changed the base branch from master to v3.2 December 3, 2017 10:35
@xificurk
Copy link
Contributor Author

xificurk commented Dec 3, 2017

@enumag rebased, but for some reason travis build was not triggered. Could you look into it?

@enumag
Copy link
Member

enumag commented Dec 3, 2017

@xificurk I have no idea why. I think I'll just merge this and we'll see potential failures on the 3.2 branch then.

Thank you!

@enumag enumag merged commit 4d62df1 into Kdyby:v3.2 Dec 3, 2017
@xificurk xificurk deleted the php72-compatibility branch December 3, 2017 11:00
@JanGalek
Copy link
Contributor

I tested change Nette\Object to trait SmartObject for current stables version of Kdyby packages, and everything looks ok :)

@enumag
Copy link
Member

enumag commented Dec 21, 2017

@JanGalek Yeah, Object issues are indeed solved. There are some other problems though - Doctrine 2.6 and RobotLoader 3.0.

@JanGalek
Copy link
Contributor

@enumag ou, Can I help ? :)

@enumag
Copy link
Member

enumag commented Dec 21, 2017

@JanGalek Sure you can. :)

For RobotLoader there is a PR #304 but it is not in a mergeable state. And it would be better if someone could figure out why is RobotLoader even used in the first place - ideally I'd like to drop it.

For Doctrine 2.6 try to install the 3.2 branch of kdyby/doctrine along with doctrine/orm 2.6 and test your app for any issues.

@JanGalek
Copy link
Contributor

@enumag thanks, I was looking for RobotLoader now, I will continue morning, I will try it ;)

@enumag enumag mentioned this pull request Jan 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants