Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package structured reworked for sealed packages #3473

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

wadoon
Copy link
Member

@wadoon wadoon commented May 24, 2024

This brings some clean-ups of the #3451 branch to main, without adding module-info.java files.

Features

  • distinct packages for each (gradle) module
  • fixing service loader files

@wadoon wadoon mentioned this pull request May 24, 2024
3 tasks
@wadoon wadoon force-pushed the weigl/pckgreworked branch from 0b3f5bd to 29e5cce Compare May 24, 2024 21:45
@wadoon wadoon changed the title Weigl/pckgreworked Package structured reworked for sealed packages May 24, 2024
@wadoon wadoon marked this pull request as ready for review May 26, 2024 15:51
@wadoon wadoon self-assigned this May 26, 2024
@wadoon wadoon added the 🛠 Maintenance Code quality and related things w/o functional changes label May 26, 2024
@wadoon wadoon added this to the v2.14.0 milestone May 26, 2024
@wadoon wadoon requested a review from WolframPfeifer June 6, 2024 09:02
wadoon and others added 6 commits June 24, 2024 15:17
* also fix some encoding in recorder/src files
- add SNAPSHOT of dockingframes
- removal of JUnit4 from root gradle
@wadoon wadoon force-pushed the weigl/pckgreworked branch from 7200b6a to 87c7a64 Compare June 24, 2024 13:21
wadoon and others added 2 commits June 24, 2024 15:22
wadoon and others added 2 commits June 26, 2024 16:12
* refs/heads/main:
  Update key.core/src/main/java/de/uka/ilkd/key/nparser/builder/TacletPBuilder.java
  spotless
  update oracle for taclet equality test
  repair soundness of assignment2UpdateRules with checked overflows
  spotless
  Changed types in replacement map for WD taclets, since PR #3436 made casting TermSV to ProgramVariable not applicable
  Fix and test goToNext()
  Fix goToNextSibling() (thx Tobias)
  Format
  Add comments and next() method
  Remove SVSubstitute
  Clean up inheritance
  Implement missing methods
  Start implementation of traversal
  Implement cursor
  Increase Java version
  API design
  throw an error if choices used in a taclet are not declared
  correct inRange(..) predicates for overflow check semantics
  fix creating of branches for overflow checking
Copy link

sonarqubecloud bot commented Jul 5, 2024

# By Tobias Reinhold (27) and others
# Via GitHub (35) and others
* origin/main: (78 commits)
  spotless update
  removed default implementations for AbstractExternalSolverRuleApp around RULE field
  small formatting change
  Bump the gradle-deps group with 6 updates
  Bump JetBrains/qodana-action in the github-actions-deps group
  set version to 2.12.4-dev
  increase java version to 21
  added missing conversion rules from javaUnaryMinusFloat/Double to negFloat/Double
  add AbstractExternalSolverRuleApp to allow other external solvers to close goals
  fixes NullPointerException, when using compareTo with locations that dont have a URI or position
  Bump the github-actions-deps group with 2 updates
  Bump the gradle-deps group with 5 updates
  formatting
  Bump the github-actions-deps group with 2 updates
  Bump the gradle-deps group with 8 updates
  spotless
  generating ProofTree tooltips lazily, options to disable them completely
  fix for visual bug with overlapping/unreadable text in color settings
  Fox copyright year
  Bump the gradle-deps group with 6 updates
  ...

# Conflicts:
#	.github/workflows/code_quality.yml
#	build.gradle
#	key.ui/src/main/java/de/uka/ilkd/key/gui/WindowUserInterfaceControl.java
#	key.ui/src/main/java/de/uka/ilkd/key/ui/util/DoNothingCaret.java
@wadoon wadoon force-pushed the weigl/pckgreworked branch from 4cad585 to a2b1d9a Compare November 17, 2024 22:10
Copy link

sonarqubecloud bot commented Dec 1, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
79 New Major Issues (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠 Maintenance Code quality and related things w/o functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant