Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the gradle-deps group with 2 updates #3542

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 1, 2025

Bumps the gradle-deps group with 2 updates: ch.qos.logback:logback-classic and com.diffplug.spotless.

Updates ch.qos.logback:logback-classic from 1.5.15 to 1.5.16

Commits
  • 74c9ebd prepare release 1.5.16
  • 9308a58 javadocs structure changed
  • 8935470 adapt test to SLF4J version 2.0.16
  • cb60369 addded StubEventEvaluator as default class for evaluator element so as to dir...
  • 1da2f17 bump jxr version
  • 5bde644 bump slf4j version to 2.0.16
  • aa2ebae remove stax related code
  • 80db86b fix issues/860
  • a8a2303 start work on 1.5.16-SNAPSHOT
  • bf14c2c minor javadoc update
  • See full diff in compare view

Updates com.diffplug.spotless from 6.25.0 to 7.0.2

Most Recent Ignore Conditions Applied to This Pull Request
Dependency Name Ignore Conditions
com.diffplug.spotless [>= 6.17.a, < 6.18]
com.diffplug.spotless [>= 6.18.a, < 6.19]
com.diffplug.spotless [>= 6.19.a, < 6.20]

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

Bumps the gradle-deps group with 2 updates: [ch.qos.logback:logback-classic](https://github.com/qos-ch/logback) and com.diffplug.spotless.


Updates `ch.qos.logback:logback-classic` from 1.5.15 to 1.5.16
- [Commits](qos-ch/logback@v_1.5.15...v_1.5.16)

Updates `com.diffplug.spotless` from 6.25.0 to 7.0.2

---
updated-dependencies:
- dependency-name: ch.qos.logback:logback-classic
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: gradle-deps
- dependency-name: com.diffplug.spotless
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: gradle-deps
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file Java Pull requests that update Java code labels Feb 1, 2025
@wadoon
Copy link
Member

wadoon commented Feb 2, 2025

@WolframPfeifer This PR brings a significant update to spotless. In the changelog, they wrote

Spotless now supports linting in addition to formatting.

The lining complains about the new binding instanceof in Java. But the description of lining is non-helpful:

Lints
Spotless is primarily a formatter, not a linter. But, if something goes wrong during formatting, it's better to model that as a lint with line numbers rather than just a naked exception. There are two ways to go about this:

at any point during the formatting process, you can throw a Lint.atLine(int line, ...) exception. This will be caught and turned into a lint.
or you can override the default List lint(String content, File file) method. This method will only run if the step did not already throw an exception.
Don't go lint crazy! By default, all lints are build failures. Users have to suppress them explicitly if they want to continue.

... needs investigation ...

@wadoon
Copy link
Member

wadoon commented Feb 2, 2025

For no reason, the eclipse formatter is not used. Instead formatting is done by google-java-format: com.google.googlejavaformat.java.FormatterException: 439:41: error: ')' expected

It could be that the import cleaner complains.

@wadoon
Copy link
Member

wadoon commented Feb 2, 2025

Fixed by using a different unused-import-remover:

            removeUnusedImports("cleanthat-javaparser-unnecessaryimport")

@wadoon wadoon enabled auto-merge February 2, 2025 23:28
@wadoon wadoon disabled auto-merge February 3, 2025 00:00
@wadoon
Copy link
Member

wadoon commented Feb 3, 2025

@WolframPfeifer The bad news is, that the new release destroys our Java switches and records. The good news is, that our eclipse config is the reason of it. Please investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants