Refactor auth0 example #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tottoto
force-pushed
the
refactor-auth0-example
branch
from
5f909b0
to
6747f0a
Compare
Keats
reviewed
Jan 21, 2024
| let kid = match header.kid { | ||
| Some(k) => k, | ||
| None => return Err("Token doesn't have a `kid` header field".into()), | ||
| let Some(kid) = header.kid else { |
There was a problem hiding this comment.
Since which version of Rust is that stable? First time I'm seeing that syntax
There was a problem hiding this comment.
let-else statements is stabilized at Rust 1.65.
https://blog.rust-lang.org/2022/11/03/Rust-1.65.0.html#let-else-statements
drath3000
added a commit
to drath3000/jsonwebtoken_for_jws
that referenced
this pull request
Mar 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decouples auth0 examples' pattern matching to the more flattened structure, and uses header's
algfor specifying the algorithm.