Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clap v4 #61

Closed
wants to merge 15 commits into from
Closed

Clap v4 #61

wants to merge 15 commits into from

Conversation

chevdor
Copy link
Contributor

@chevdor chevdor commented Jan 12, 2023

  • Update to clap 4
  • update deps
  • fix string formatting

Keats
Keats requested changes Jan 12, 2023
View reviewed changes
src/bin/kickstart.rs Outdated
.about(crate_description!())
.setting(AppSettings::SubcommandsNegateReqs)
pub fn build_cli() -> Command {
command!()
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we switch to using the struct way instead of the macro?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, there are also a few other issues I am addressing.

@chevdor
Copy link
Contributor Author

chevdor commented Jan 13, 2023

I am getting an error about the template.toml being missing whereas it is not, not sure yet what is going on there.

@Keats
Copy link
Owner

Keats commented Jan 13, 2023

The error for the CI is probably just needing to bump the msrv

@chevdor
Copy link
Contributor Author

chevdor commented Jan 13, 2023

I am seeing usage errors as well. So I think this is not 100% ready. I need to dig since I don't get the error.
I am fetching and providing a valid template.toml but the app complains about the file not existing.

@Keats
Copy link
Owner

Keats commented Aug 1, 2023

I'm doing it in #62

@Keats Keats closed this Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keats Keats Keats requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chevdor @Keats