Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport changes made to tera #928

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Conversation

cheesycod
Copy link

NOTE: This PR is not intended to be merged as-is. Its just a PR of the changes made in case upstream wants to use parts of it for themselves.

@Keats
Copy link
Owner

Keats commented Jul 11, 2024

Backport from where? None of this will be merged since https://github.com/Keats/tera2 is a brand new codebase, all from scratch but is in the beta state right now.

@cheesycod
Copy link
Author

cheesycod commented Jul 16, 2024

Backport from where? None of this will be merged since https://github.com/Keats/tera2 is a brand new codebase, all from scratch but is in the beta state right now.

Project I am a part of uses tera with patches for async support. Not intended to be merged whatsoever

@Keats
Copy link
Owner

Keats commented Jul 17, 2024

What are the async things you are doing in the templates?

@cheesycod
Copy link
Author

What are the async things you are doing in the templates?

Well, right now, just adding a pathway which is async/await (which should also allow tokio::timeout to work better/yield)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants